vitalybuka added inline comments.

================
Comment at: clang/lib/CodeGen/CGClass.cpp:1773
       // function
-      EmitSanitizerDtorCallback(CGF, VTablePtr, PoisonSize);
+      EmitSanitizerDtorCallback(CGF, "__sanitizer_dtor_callback_vptr",
+                                VTablePtr);
----------------
kstoimenov wrote:
> Should this be a constant? 
it would be nice if we can share constants with runtime, but as is 
clang/compiler-rt do not include each other
without reuse I don't see a point in named constant.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132907/new/

https://reviews.llvm.org/D132907

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to