aaron.ballman updated this revision to Diff 457289.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Herald added subscribers: sstefan1, arphaman.
Herald added a reviewer: jdoerfert.
Because I'm touching this file so much anyway to add the GitHub handles, I had
some ideas I wanted to float to see if others thought they were worthwhile:
1. I'd like to rearrange the file so that we don't organize it by surname
(slightly problematic given that not everyone has a surname or goes by their
given name anyway) but instead organize it by component. I think most of the
people who are going to be interested in the contents of this file are going to
be looking for a component to find a name instead of looking for a name to find
a component.
2. I'd like to convert the file to RST format. This not only gives us some
nicer ways to categorize the file contents, but it also makes it easier to
publish this file on the website along with our other developer policy
documentation.
3. It gives us a nice way to organize former code owners without making it more
difficult to find active code owners (I did not try to find all former code
owners)
This latest patch shows you what I have in mind for the changes. I'm not
strongly tied to making the file into RST as that does reduce the readability
of the text file somewhat, but I think the benefits to making this
documentation more public outweigh the downsides to using markup.
(If someone knows of a way to get RST to style headings that are cut off the
local table of contents due to the `:depth:` annotation, that would be lovely.
Right now, the third level headings are as visually distinct as I'd like
because the local table of contents is limited to two levels of nesting.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132550/new/
https://reviews.llvm.org/D132550
Files:
clang-tools-extra/CODE_OWNERS.TXT
clang/CODE_OWNERS.TXT
clang/CodeOwners.rst
clang/docs/CodeOwners.rst
clang/docs/index.rst
Index: clang/docs/index.rst
===================================================================
--- clang/docs/index.rst
+++ clang/docs/index.rst
@@ -98,6 +98,7 @@
.. toctree::
:maxdepth: 1
+ CodeOwners
InternalsManual
DriverInternals
OffloadingDesign
Index: clang/docs/CodeOwners.rst
===================================================================
--- /dev/null
+++ clang/docs/CodeOwners.rst
@@ -0,0 +1 @@
+.. include:: ../CodeOwners.rst
Index: clang/CodeOwners.rst
===================================================================
--- /dev/null
+++ clang/CodeOwners.rst
@@ -0,0 +1,256 @@
+=================
+Clang Code Owners
+=================
+
+This file is a list of the people responsible for ensuring that patches for a
+particular part of Clang are reviewed, either by themself or by someone else.
+They are also the gatekeepers for their part of Clang, with the final word on
+what goes in or not.
+
+.. contents::
+ :depth: 2
+ :local:
+
+Current Code Owners
+===================
+The following people are the active code owners for the project. Please reach
+out to them for code reviews, questions about their area of expertise, or other
+assistance.
+
+All parts of Clang not covered by someone else
+----------------------------------------------
+| Aaron Ballman
+| aaron\@aaronballman.com (email), aaron.ballman (Phabricator), AaronBallman (GitHub)
+
+
+Contained Components
+--------------------
+These code owners are responsible for particular high-level components within
+Clang that are typically contained to one area of the compiler.
+
+AST matchers
+~~~~~~~~~~~~
+| Manuel Klimek
+| klimek\@google.com (email), klimek (Phabricator), r4nt (GitHub)
+
+
+Clang LLVM IR generation
+~~~~~~~~~~~~~~~~~~~~~~~~
+| John McCall
+| rjmccall\@apple.com (email), rjmccall (Phabricator), rjmccall (GitHub)
+
+| Eli Friedman
+| efriedma\@quicinc.com (email), efriedma (Phabricator), efriedma-quic (GitHub)
+
+| Anton Korobeynikov
+| anton\@korobeynikov.info (email), asl (Phabricator), asl (GitHub)
+
+
+Analysis & CFG
+~~~~~~~~~~~~~~
+| Dmitri Gribenko
+| gribozavr\@gmail.com (email), gribozavr (Phabricator), gribozavr (GitHub)
+
+| Yitzhak Mandelbaum
+| yitzhakm\@google.com (email), ymandel (Phabricator), ymand (GitHub)
+
+| Stanislav Gatev
+| sgatev\@google.com (email), sgatev (Phabricator), sgatev (GitHub)
+
+
+Modules & serialization
+~~~~~~~~~~~~~~~~~~~~~~~
+| Chuanqi Xu
+| yedeng.yd\@linux.alibaba.com (email), ChuanqiXu (Phabricator), ChuanqiXu9 (GitHub)
+
+| Michael Spencer
+| bigcheesegs\@gmail.com (email), Bigcheese (Phabricator), Bigcheese (GitHub)
+
+
+Templates
+~~~~~~~~~
+| Erich Keane
+| erich.keane\@intel.com (email), ErichKeane (Phabricator), erichkeane (GitHub)
+
+
+Debug information
+~~~~~~~~~~~~~~~~~
+| Eric Christopher
+| echristo\@gmail.com (email), echristo (Phabricator), echristo (GitHub)
+
+
+Exception handling
+~~~~~~~~~~~~~~~~~~
+| Anton Korobeynikov
+| anton\@korobeynikov.info (email), asl (Phabricator), asl (GitHub)
+
+
+Clang static analyzer
+~~~~~~~~~~~~~~~~~~~~~
+| Artem Dergachev
+| adergachev\@apple.com (email), NoQ (Phabricator), haoNoQ (GitHub)
+
+| Gábor Horváth
+| xazax.hun\@gmail.com (email), xazax.hun (Phabricator), Xazax-hun (GitHub)
+
+
+Compiler options
+~~~~~~~~~~~~~~~~
+| Jan Svoboda
+| jan_svoboda\@apple.com (email), jansvoboda11 (Phabricator), jansvoboda11 (GitHub)
+
+
+OpenBSD driver
+~~~~~~~~~~~~~~
+| Brad Smith
+| brad\@comstyle.com (email), brad (Phabricator), brad0 (GitHub)
+
+
+Driver parts not covered by someone else
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+| Fangrui Song
+| maskray\@google.com (email), MaskRay (Phabricator), MaskRay (GitHub)
+
+
+Tools
+-----
+These code owners are responsible for user-facing tools under the Clang
+umbrella or components used to support such tools.
+
+Tooling library
+~~~~~~~~~~~~~~~
+| Manuel Klimek
+| klimek\@google.com (email), klimek (Phabricator), r4nt (GitHub)
+
+
+clang-format
+~~~~~~~~~~~~
+| MyDeveloperDay
+| mydeveloperday\@gmail.com (email), MyDeveloperDay (Phabricator), MyDeveloperDay (GitHub)
+
+| Owen Pan
+| owenpiano\@gmail.com (email), owenpan (Phabricator), owenca (GitHub)
+
+
+ABIs
+----
+The following people are responsible for decisions involving ABI.
+
+Itanium ABI
+~~~~~~~~~~~
+| John McCall
+| rjmccall\@apple.com (email), rjmccall (Phabricator), rjmccall (GitHub)
+
+
+Microsoft ABI
+~~~~~~~~~~~~~
+| Reid Kleckner
+| rnk\@google.com (email), rnk (Phabricator), rnk (GitHub)
+
+
+ARM EABI
+~~~~~~~~
+| Anton Korobeynikov
+| anton\@korobeynikov.info (email), asl (Phabricator), asl (GitHub)
+
+
+Compiler-Wide Topics
+--------------------
+The following people are responsible for functionality that does not fit into
+a single part of the compiler, but instead span multiple components within the
+compiler.
+
+Attributes
+~~~~~~~~~~
+| Erich Keane
+| erich.keane\@intel.com (email), ErichKeane (Phabricator), erichkeane (GitHub)
+
+
+Inline assembly
+~~~~~~~~~~~~~~~
+| Eric Christopher
+| echristo\@gmail.com (email), echristo (Phabricator), echristo (GitHub)
+
+
+Text encodings
+~~~~~~~~~~~~~~
+| Tom Honermann
+| tom\@honermann.net (email), tahonermann (Phabricator), tahonermann (GitHub)
+
+| Corentin Jabot
+| corentin.jabot\@gmail.com (email), cor3ntin (Phabricator), cor3ntin (GitHub)
+
+
+CMake integration
+~~~~~~~~~~~~~~~~~
+| Petr Hosek
+| phosek\@google.com (email), phosek (Phabricator), petrhosek (GitHub)
+
+| John Ericson
+| git\@johnericson.me (email), Ericson2314 (Phabricator), Ericson2314 (GitHub
+
+
+General Windows support
+~~~~~~~~~~~~~~~~~~~~~~~
+| Reid Kleckner
+| rnk\@google.com (email), rnk (Phabricator), rnk (GitHub)
+
+
+Standards Conformance
+---------------------
+The following people are responsible for validating that changes are conforming
+to a relevant standard. Contact them for questions about how to interpret a
+standard, when fixing standards bugs, or when implementing a new standard feature.
+
+C conformance
+~~~~~~~~~~~~~
+| Aaron Ballman
+| aaron\@aaronballman.com (email), aaron.ballman (Phabricator), AaronBallman (GitHub)
+
+
+C++ conformance
+~~~~~~~~~~~~~~~
+| Hubert Tong
+| hubert.reinterpretcast\@gmail.com (email), hubert.reinterpretcast (Phabricator), hubert-reinterpretcast (GitHub)
+
+
+Objective-C/C++ conformance
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+| John McCall
+| rjmccall\@apple.com (email), rjmccall (Phabricator), rjmccall (GitHub)
+
+
+OpenMP conformance
+~~~~~~~~~~~~~~~~~~
+| Alexey Bataev
+| a.bataev\@hotmail.com (email), ABataev (Phabricator), cilkplus (GitHub)
+
+
+OpenCL conformance
+~~~~~~~~~~~~~~~~~~
+| Anastasia Stulova
+| anastasia.stulova\@arm.com (email), Anastasia (Phabricator), AnastasiaStulova (GitHub)
+
+
+SYCL conformance
+~~~~~~~~~~~~~~~~
+| Alexey Bader
+| alexey.bader\@intel.com (email), bader (Phabricator), bader (GitHub)
+
+
+Former Code Owners
+==================
+The following people have graciously spent time performing code ownership
+responsibilities but are no longer active in that role. Thank you for all your
+help with the success of the project!
+
+Emeritus owners
+---------------
+| Doug Gregor (dgregor\@apple.com)
+| Richard Smith (richard\@metafoo.co.uk)
+
+
+Former component owners
+-----------------------
+| Chandler Carruth (chandlerc\@gmail.com, chandlerc\@google.com) -- CMake, library layering
+| Devin Coughlin (dcoughlin\@apple.com) -- Clang static analyzer
Index: clang/CODE_OWNERS.TXT
===================================================================
--- clang/CODE_OWNERS.TXT
+++ /dev/null
@@ -1,66 +0,0 @@
-This file is a list of the people responsible for ensuring that patches for a
-particular part of Clang are reviewed, either by themself or by someone else.
-They are also the gatekeepers for their part of Clang, with the final word on
-what goes in or not.
-
-The list is sorted by surname and formatted to allow easy grepping and
-beautification by scripts. The fields are: name (N), email (E), web-address
-(W), PGP key ID and fingerprint (P), description (D), and snail-mail address
-(S).
-
-N: Alexey Bader
-E: alexey.ba...@intel.com
-D: SYCL support
-
-N: Aaron Ballman
-E: aa...@aaronballman.com
-D: Clang attributes
-
-N: Alexey Bataev
-E: a.bat...@hotmail.com
-D: OpenMP support
-
-N: Chandler Carruth
-E: chandl...@gmail.com
-E: chandl...@google.com
-D: CMake, library layering
-
-N: Eric Christopher
-E: echri...@gmail.com
-D: Debug Information, inline assembly
-
-N: Devin Coughlin
-E: dcough...@apple.com
-D: Clang Static Analyzer
-
-N: Doug Gregor
-E: dgre...@apple.com
-D: Emeritus owner
-
-N: Reid Kleckner
-E: r...@google.com
-D: Microsoft C++ ABI compatibility and general Windows support
-
-N: Manuel Klimek
-E: kli...@google.com
-D: AST matchers, LibTooling
-
-N: Anton Korobeynikov
-E: an...@korobeynikov.info
-D: Exception handling, Windows codegen, ARM EABI
-
-N: John McCall
-E: rjmcc...@apple.com
-D: Clang LLVM IR generation
-
-N: Brad Smith
-E: b...@comstyle.com
-D: OpenBSD driver
-
-N: Richard Smith
-E: rich...@metafoo.co.uk
-D: All parts of Clang not covered by someone else
-
-N: Anastasia Stulova
-E: anastasia.stul...@arm.com
-D: OpenCL support
Index: clang-tools-extra/CODE_OWNERS.TXT
===================================================================
--- clang-tools-extra/CODE_OWNERS.TXT
+++ clang-tools-extra/CODE_OWNERS.TXT
@@ -4,26 +4,27 @@
in or not.
The list is sorted by surname and formatted to allow easy grepping and
-beautification by scripts. The fields are: name (N), email (E), web-address
-(W), PGP key ID and fingerprint (P), description (D), and snail-mail address
-(S).
+beautification by scripts. The fields are: name (N), email (E), Phabricator
+handle (H), and description (D).
N: Aaron Ballman
E: aa...@aaronballman.com
+H: aaron.ballman
D: clang-query
-N: Manuel Klimek
-E: kli...@google.com
-D: clang-rename, all parts of clang-tools-extra not covered by someone else
-
-N: Alexander Kornienko
-E: ale...@google.com
-D: clang-tidy
-
N: Julie Hockett
E: juliehock...@google.com
D: clang-doc
+N: Nathan James
+E: n.jame...@hotmail.co.uk
+H: njames93
+D: clang-tidy
+
+N: Manuel Klimek
+E: kli...@google.com
+D: clang-rename, all parts of clang-tools-extra not covered by someone else
+
N: Sam McCall
E: sammcc...@google.com
D: clangd
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
