ChuanqiXu added a comment.
The summary looks good and I don't make a review in depth due to it is indeed
large... (I'll see if I can take a deeper review)
================
Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:890-893
+ struct {
+ bool DoIt;
+ FunctionDecl *Existing = nullptr;
+ } Merge = {false};
----------------
Is this struct necessary? I feel two separate variables may be more clear.
================
Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626
+ VisitDeclaratorDecl(D);
+ Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName());
+ Record.push_back(D->getIdentifierNamespace());
+
----------------
I still don't get the reason for the move. What's the benefit? Or why is it
necessary?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131858/new/
https://reviews.llvm.org/D131858
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
