ChuanqiXu added inline comments.
================ Comment at: clang/include/clang/AST/ASTContext.h:1369 } + QualType getDecayedType(QualType T, QualType Decayed) const; ---------------- mizvekov wrote: > ChuanqiXu wrote: > > Maybe we need a comment for this. The signature looks not straight forward > > and I can't relate this to the above comment. > I think I wanted to make this an internal variant, since we will probably > never need this outside of ASTContext anyway, but there is the friendship > situation between Type and ASTContext. Maybe making this private would be for > the best. Yeah, the signature confused me as well... as long as the second parameter is `Decayed` already, why we need to get the decayed type again? I guess `Underlying` may be a better name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
