aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed.
Thanks for the cleanup here! Precommit CI pointed out places where test coverage found issues, and you're missing new test coverage for the change. If you run the failing `constant-expression-cxx11.cpp` test in an asserts build, it'll help you to narrow down where the issue is. I think the problem is that there are more instances of issuing `diag::note_constexpr_invalid_cast` with the trailing argument `2` that weren't updated to pass the additional trailing argument you added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133194/new/ https://reviews.llvm.org/D133194 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
