aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a nit that was missed. Thanks for switching to static_cast, that makes me happier. :-) ================ Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:109 + if (Template) { + if (const auto TTD = dyn_cast<TemplateTypeParmDecl>( + Template->getTemplateParameters()->getParam(0))) ---------------- Missed from the previous suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131268/new/ https://reviews.llvm.org/D131268 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits