MaskRay accepted this revision. MaskRay added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:1687 +def fexperimental_sanitize_metadata_EQ : CommaJoined<["-"], "fexperimental-sanitize-metadata=">, + Group<f_clang_Group>, + HelpText<"Specify the type of metadata to emit for binary analysis sanitizers">; ---------------- You can use f_Group instead of f_clang_Group. There are so many clang-specific (not in gcc) options, so the group is not useful. Remove `NoXarchOption`. ================ Comment at: clang/test/Driver/fsanitize-metadata.c:1 +// RUN: %clang --target=x86_64-linux-gnu -fexperimental-sanitize-metadata=all -fno-experimental-sanitize-metadata=all %s -### 2>&1 | FileCheck %s +// CHECK-NOT: -fexperimental-sanitize-metadata ---------------- -fno-experimental-sanitize-metadata= works on bitmasks. You can change this run line to remove one bit instead of all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130888/new/ https://reviews.llvm.org/D130888 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
