steven_wu added a comment. In D131469#3768308 <https://reviews.llvm.org/D131469#3768308>, @dongjunduo wrote:
> In D131469#3768288 <https://reviews.llvm.org/D131469#3768288>, @dyung wrote: > >> In D131469#3768283 <https://reviews.llvm.org/D131469#3768283>, @dongjunduo >> wrote: >> >>> In D131469#3768282 <https://reviews.llvm.org/D131469#3768282>, @dyung wrote: >>> >>>> In D131469#3768274 <https://reviews.llvm.org/D131469#3768274>, @dongjunduo >>>> wrote: >>>> >>>>> In D131469#3768260 <https://reviews.llvm.org/D131469#3768260>, @dyung >>>>> wrote: >>>>> >>>>>> The test you added is failing on the PS4 linux bot because the PS4 >>>>>> platform requires an external linker that isn't present. Is linking >>>>>> necessary for your test? Or can -S or even -c work instead to accomplish >>>>>> what you are trying to test? >>>>> >>>>> Yeah the new test case is designed to test the compiling jobs with a >>>>> linking stage. >>>>> >>>>> Are there any options or measures to avoid this test running on the PS4? >>>> >>>> You could mark it as XFAIL: ps4 >>>> >>>> Your change also seems to have possibly the same issue when run on our PS5 >>>> Windows bot: >>>> https://lab.llvm.org/buildbot/#/builders/216/builds/9260 >>>> >>>> $ ":" "RUN: at line 2" >>>> $ "z:\test\build\bin\clang.exe" "--driver-mode=g++" "-ftime-trace" >>>> "-ftime-trace-granularity=0" "-o" >>>> "Z:\test\build\tools\clang\test\Driver\Output/exe/check-time-trace" >>>> "Z:\test\llvm-project\clang\test\Driver\check-time-trace.cpp" >>>> # command stderr: >>>> clang: error: unable to execute command: program not executable >>>> clang: error: linker command failed with exit code 1 (use -v to see >>>> invocation) >>> >>> How about "**UNSUPPORTED: ps4, ps5**" >> >> That would likely work I think. > > Done with the commit 39221ad > <https://github.com/llvm/llvm-project/commit/39221ad55752c246bb8448a181847103432e12b2>. I don't like how this done. This generally won't work for Darwin platform as well since you don't know where SDK is. Whether you have a linker or not has nothing to do with the host platform, you need to check for if the linker is available. This is also a regression in test coverage since all the supported tests in lines after you added are no longer executed on the platform you excludes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
