inclyc added inline comments.
================
Comment at: clang/lib/Parse/ParseDecl.cpp:5340
+ if (!getLangOpts().CPlusPlus)
+ return false;
if (NextToken().is(tok::kw_new) || // ::new
----------------
Maybe we can make a new `error` diagnostic definition and fire that here?
================
Comment at: clang/test/Parser/c2x-attributes.c:146
+// Ensure that '::' outside of attributes does not crash and is not treated as
scope
+double n::v; // expected-error {{expected ';' after top level declarator}}
----------------
Could we improve this diagnostic message?
```
expected ';' after top level declarator}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133248/new/
https://reviews.llvm.org/D133248
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
