t.p.northover added a comment. > I don't think this is quite correct though? It'll turn off unwind tables for > AArch64 entirely, whereas we want to keep sync unwind tables.
You're right, sorry about that. Hopefully this refactoring with MaskRay's suggestion gets it right. ================ Comment at: clang/include/clang/Driver/ToolChain.h:501 + /// IsAsyncUnwindTablesDefault - Does this tool chain use + /// -fasync-unwind-tables by default. + virtual bool ---------------- MaskRay wrote: > smeenai wrote: > > I believe the option is spelled `-fasynchronous-unwind-tables`. > Changing `IsUnwindTablesDefault` to `unwindTablesDefaultLevel` may be > cleaner. I prefer it, though the Clang.cpp logic is unavoidably weird. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131153/new/ https://reviews.llvm.org/D131153 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
