mtrofin added a comment. In D132991#3764877 <https://reviews.llvm.org/D132991#3764877>, @aidengrossman wrote:
> @xur I've modified the patch slightly (mainly fixing tests and changing the > error message printing in `CodeGenModule` to an assert as we should be > capturing everything in `CompilerInvocation`. Do you mind looking over these > changes, specifically making sure that going through CompilerInvocation is > always guaranteed if we end up hitting `CodeGenModule`? How come the old error checking in CodeGenModule wasn't tripped before? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132991/new/ https://reviews.llvm.org/D132991 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits