Navidem marked an inline comment as done and an inline comment as not done. Navidem added inline comments.
================ Comment at: clang/lib/Driver/SanitizerArgs.cpp:807 << "-fsanitize-coverage=[func|bb|edge]" - << "-fsanitize-coverage=[func|bb|edge],[trace-pc-guard|trace-pc]"; + << "-fsanitize-coverage=[func|bb|edge],[trace-pc-guard|trace-pc|control-flow]"; } ---------------- vitalybuka wrote: > shouldn't this be: > ,[trace-pc-guard|trace-pc],[control-flow] > > probably even: > [,(trace-pc-guard|trace-pc)][,control-flow] > shouldn't this be: > ,[trace-pc-guard|trace-pc],[control-flow] > > probably even: > [,(trace-pc-guard|trace-pc)][,control-flow] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits