mstorsjo added a comment.

In D133773#3786484 <https://reviews.llvm.org/D133773#3786484>, @alvinhochun 
wrote:

> Ah sorry about that, I didn't realize the command includes `.exe` on Windows. 
> (For the record, `ld"` matches both `ld` and `ld.lld`.)

No, iirc these quotes are checked as literal part of the matched string here; 
otherwise the pattern `ld"` would match `ld.exe"` too. So to match any linker 
name, I'd write `ld{{.*}}"` or maybe something like `ld{{[\.a-z]*}}"`, modulo 
regex syntax.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133773/new/

https://reviews.llvm.org/D133773

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to