beanz added inline comments.
================ Comment at: clang/lib/Driver/Driver.cpp:5459 + if (AtTopLevel && !isa<DsymutilJobAction>(JA) && !isa<VerifyJobAction>(JA) && + !(IsDXCMode() && C.getArgs().hasArg(options::OPT__SLASH_P))) { if (Arg *FinalOutput = C.getArgs().getLastArg(options::OPT_o)) ---------------- Why is this change needed? Didn't we settle on having `/P` behave the way CL.exe does? ================ Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:181 + if (DAL->hasArg(options::OPT__SLASH_P)) + getDriver().Diag(diag::warn_drv_dxc_ignore_output_for_preprocess) << "Fo"; + ---------------- This warning should fire in CL mode too right? Should it not be dxc-specific? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits