shafik added a comment.

Thank you for doing this work.



================
Comment at: llvm/lib/Support/UnicodeCaseFold.cpp:713
+  // 8 characters
+  if (C <= 0xa7c2)
     return C | 1;
----------------
Maybe I am misunderstanding the comments but should this be `0xa7be`?


================
Comment at: llvm/lib/Support/UnicodeNameToCodepoint.cpp:254
 
-// Unicode 14.0
+// Unicode 15.0
 // 3.12 Conjoining Jamo Behavior Common constants
----------------
You use `15.0` here and `15.` above, any reason for the difference?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133807/new/

https://reviews.llvm.org/D133807

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to