dongjunduo added inline comments.
================ Comment at: clang/lib/Driver/Driver.cpp:4516 + bool HasTimeTrace = C.getArgs().hasArg(options::OPT_ftime_trace); + bool HasTimeTraceFile = C.getArgs().hasArg(options::OPT_ftime_trace_EQ); + // Whether `-ftime-trace` or `-ftime-trace=<path>` are specified ---------------- MaskRay wrote: > Change this variable to use `getLastArg(options::OPT_ftime_trace_EQ)` instead. > > The convention is to use getLastArg if both hasArg and getLastArg are needed. Emmm, do you means `HasTimeTrace` and `HasTimeTraceFile`'s initialized approach shoud be reverted into the last version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131469/new/ https://reviews.llvm.org/D131469 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
