azat added a comment.

> Presumably this would break if someone's build uses a tool suffix (so lld 
> becomes lld-tot or something like that)? Perhaps lld[^"]*" would be better?

I thought about this too, but I found this in another test, so likely it should 
work...

> Are there other test cases that test something similar that we could look at 
> to see how they work/more likely get something that works as well?

This one is copied from `clang/test/Driver/debug-options-lld.c`

Anyway I need to resubmit the initial patch since it got reverted.
But I don't see close button here, only trusted users can do this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133847/new/

https://reviews.llvm.org/D133847

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to