rnk added a comment.

I agree, there's no reason to change the i686 MSVC record layout algorithm. It 
was written, tested, done, it's fragile. We used to have some decent continuous 
integration testing for ABI issues like this, but as usual these things require 
care and feeding and it did not survive the passage of time.

This patch implements the new GCC behavior, right? Reject arrays when size is 
not a multiple of alignment? That sounds good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133711/new/

https://reviews.llvm.org/D133711

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to