Navidem marked 3 inline comments as done. Navidem added inline comments.
================ Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:15 +extern "C" void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, + const uintptr_t *cfs_end) { + CFS_BEG = (uintptr_t *)cfs_beg; ---------------- vitalybuka wrote: > Navidem wrote: > > vitalybuka wrote: > > > vitalybuka wrote: > > > > would you like to add some printing function as for other coverage > > > > types? > > > actually printing can be don't in follow up patch, but it may simplify > > > the test, you will not need iterate it in the test. > > > actually printing can be don't in follow up patch, but it may simplify > > > the test, you will not need iterate it in the test. > > > > I'm not sure I follow what you are suggesting. > Check this out D108405 > then you can hook your data into DumpCoverage() > then you can replace entire "while (pt < CFS_END) {" loop with set of CHECK: > Check this out D108405 > then you can hook your data into DumpCoverage() > then you can replace entire "while (pt < CFS_END) {" loop with set of CHECK: I see, thanks for the pointer. I think I leave it for later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits