erichkeane added a comment.

Can you clarify what the intent of this patch is?  Perhaps I'm just being slow 
today, but I don't really get the intent here.



================
Comment at: clang/lib/AST/Interp/InterpStack.h:135
+      return PT_Ptr;
+    else if (std::is_same<T, bool>::value || std::is_same<T, Boolean>::value)
+      return PT_Bool;
----------------
Each of these ALSO need to be 'if constexpr' I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133941/new/

https://reviews.llvm.org/D133941

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to