mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed.
Unfortunately, we have some test failures after this change, e.g.: FAIL: Clang :: CodeGenHLSL/basic_types.hlsl (6525 of 15795) ******************** TEST 'Clang :: CodeGenHLSL/basic_types.hlsl' FAILED ******************** Script: -- : 'RUN: at line 1'; /var/tmp/portage/sys-devel/clang-16.0.0_pre20220915/work/x/y/clang-abi_x86_32.x86/bin/clang --driver-mode=dxc -Tlib_6_7 -fcgl -Fo - /var/tmp/portage/sys-devel/clang-16.0.0_pre20220915/work/clang/test/CodeGenHLSL/basic_types.hlsl | /usr/lib/llvm/16/bin/FileCheck /var/tmp/portage/sys-devel/clang-16.0.0_pre20220915/work/clang/test/CodeGenHLSL/basic_types.hlsl -- Exit Code: 2 Command Output (stderr): -- + : 'RUN: at line 1' + /usr/lib/llvm/16/bin/FileCheck /var/tmp/portage/sys-devel/clang-16.0.0_pre20220915/work/clang/test/CodeGenHLSL/basic_types.hlsl + /var/tmp/portage/sys-devel/clang-16.0.0_pre20220915/work/x/y/clang-abi_x86_32.x86/bin/clang --driver-mode=dxc -Tlib_6_7 -fcgl -Fo - /var/tmp/portage/sys-devel/clang-16.0.0_pre20220915/work/clang/test/CodeGenHLSL/basic_types.hlsl clang-16: error: unknown argument: '--gcc-install-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/12.2.1' FileCheck error: '<stdin>' is empty. FileCheck command line: /usr/lib/llvm/16/bin/FileCheck /var/tmp/portage/sys-devel/clang-16.0.0_pre20220915/work/clang/test/CodeGenHLSL/basic_types.hlsl -- ******************** Unfortunately, within the current config framework, it's impossible to set options per `--driver-mode=...` (and i'm not convinced we really want to pursue keeping a bunch of config files to figure out which driver modes use GCC and which do not). Would it be feasible to add this option (and other similar options — e.g. `-rtlib`, `-unwindlib`, `-stdlib`) to all drivers, and make them emit `argument unused` warnings like `-fuse-ld`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/ https://reviews.llvm.org/D133329 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits