mstorsjo added a comment.
I think this looks reasonable to me - if noone else has time to approve it, I
guess I could, but I'd rather have the more authoritative reviewers complete
their reviews.
================
Comment at: llvm/utils/UpdateTestChecks/common.py:330
OPT_FUNCTION_RE = re.compile(
-
r'^(\s*;\s*Function\sAttrs:\s(?P<attrs>[\w\s]+?))?\s*define\s+(?:internal\s+)?[^@]*@(?P<func>[\w.$-]+?)\s*'
+
r'^(\s*;\s*Function\sAttrs:\s(?P<attrs>[\w\s]+?))?\s*define\s+(?:internal\s+)?[^@]*@(?P<func>[\w.$-]+?|".+?")\s*'
r'(?P<args_and_sig>\((\)|(.*?[\w.-]+?)\))[^{]*\{)\n(?P<body>.*?)^\}$',
----------------
I dunno what the practice is for updates to this script - should this change be
split out and committed separately? (I guess we don't have tests for the script
itself?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125419/new/
https://reviews.llvm.org/D125419
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
