RIscRIpt added a comment. I am new to `arc`, I tried `arc diff --edit --verbatim` as it's said in the docs, but it still created a new revision: https://reviews.llvm.org/D134458
================ Comment at: clang/lib/Sema/SemaStmtAttr.cpp:296 + // Validation is in Sema::ActOnAttributedStmt(). + return ::new (S.Context) MSConstexprAttr(S.Context, A); +} ---------------- erichkeane wrote: > Typically we try to do the ::Create function that is generated for > attributes, rather than placement new. I realize we are consistently > inconsistent... I could address this, but could you please provide an example? Because all `handle` functions in this file use placement new. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133853/new/ https://reviews.llvm.org/D133853 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
