aaron.ballman added inline comments.

================
Comment at: clang/include/clang/Sema/Sema.h:3279
                  bool IsTypeSpecifier, bool IsTemplateParamOrArg,
+                 bool IsWithinOffsetOf, bool IsOffsetOfInMacro,
                  SkipBodyInfo *SkipBody = nullptr);
----------------
inclyc wrote:
> aaron.ballman wrote:
> > Instead of passing two `bool`s, why not pass `Parser::OffsetOfStateKind` 
> > directly?
> `Parser::OffsetOfStateKind` is not visible to class `Sema`?
Sure, but it's a new enum, so we can put it into `Sema` if we want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133574/new/

https://reviews.llvm.org/D133574

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to