silvas added a comment. LGTM with some small wording nits.
We may want to extend this to mention number modifier to `%m` (e.g. `%4m`). Perhaps it is better to leave that to more advanced documentation -- your experiments showed that even just 1 merge pool is quite scalable IIRC. ================ Comment at: docs/UsersManual.rst:1500 @@ +1499,3 @@ + name. When this specifier is used, the profiler runtime will substitute ``%m`` + with a unique integer identifier associated with the instrumented binary. Multiple + profiles dumped from different processes (running on the same or different hosts) ---------------- I would suggest saying `Additionally, multiple...` instead of just `Multiple` to highlight that this is an additional behavior that is caused by using `%m`. ================ Comment at: docs/UsersManual.rst:1501 @@ +1500,3 @@ + with a unique integer identifier associated with the instrumented binary. Multiple + profiles dumped from different processes (running on the same or different hosts) + will be automatically merged by the profiler runtime during the dumping. If ---------------- You probably want to say "raw profiles" instead of just "profile" to clarify that this is a different sense of "merge" than `llvm-profdata merge ...` (or otherwise clarify). https://reviews.llvm.org/D22593 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
