azat marked 2 inline comments as done. azat added inline comments.
================ Comment at: clang/test/Driver/debug-options-aranges.c:5 +// +// RUN: %clang -### -g -target x86_64-linux -flto -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck %s +// RUN: %clang -### -g -target x86_64-linux -flto=thin -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck %s ---------------- MaskRay wrote: > azat wrote: > > MaskRay wrote: > > > Avoid legacy `-target `. Delete `-fuse-ld=lld` which is unneeded. > > >Delete -fuse-ld=lld which is unneeded > > > > I've tried without it and in some env it may try to use gold, which will > > not be available on CI and the test will fail. > > Do you have suggestions on how to overcome this? Required gold so as ld? Or > > leaving `-fuse-ld=lld` is fine? > `-###` does not run the command. This shall pass in any environment. You right, I forgot that real execution of commands had been removed in the latest version of the patch. Thanks. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133092/new/ https://reviews.llvm.org/D133092 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
