mgorny marked 2 inline comments as done. mgorny added inline comments.
================ Comment at: clang/lib/Driver/Driver.cpp:1065-1080 + StringRef EffectiveDriverMode; + if (CLOptions) + EffectiveDriverMode = CLOptions->getLastArgValue(options::OPT_driver_mode); + if (EffectiveDriverMode.empty()) + EffectiveDriverMode = ClangNameParts.DriverMode; + + llvm::Triple EffectiveTriple = ---------------- MaskRay wrote: > mgorny wrote: > > This part is mostly proof-of-concept, I need to look into how to do this > > properly. > The next common mentions "second part" but it isn't very clear what "first > part" and "second part" mean. > Perhaps repeat <triple>.cfg here and replace "second part" with "<mode>.cfg" Oh, it's so weird because the comment was moved when I was swapping the logic but didn't notice it needs to be updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
