mgorny added inline comments.
================
Comment at: clang/test/Driver/lit.local.cfg:8
- ('%clang_cc1',
- """*** Do not use 'clang -cc1' in Driver tests. ***""") )
----------------
MaskRay wrote:
> probinson wrote:
> > But we _don't_ want to use `%clang_cc1` in Driver tests; if we do, then
> > we're not testing the driver! Those tests really belong somewhere else,
> > like Frontend.
> Sorry, I missed this change. I think a lot of `%clang -cc1` tests in
> test/Driver are actually wrong and should be moved to appropriate components.
>
> The test/Driver part of this patch should be reverted.
I agree we don't want these tests there but 1) does anyone really volunteer to
fix the problem, and 2) did the substitution override really prevent people
from adding more wrong tests? I'm not against this, not at all. Just feel like
we're fighting windmills here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134880/new/
https://reviews.llvm.org/D134880
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
