aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM with one small testing nit, but you should wait for @rsmith to chime in 
since he had comments previously.


================
Comment at: test/SemaCXX/flexible-array-attr.cpp:52
@@ +51,3 @@
+  int a[4];
+  int b[4] __attribute__((flexible_array)); // expected-error 
{{'flexible_array' attribute only applies to the last member of a non-union 
class}}
+};
----------------
Would be good to change this to b[1] so that it looks like an otherwise 
well-formed construct. Should not change the diagnostic.


https://reviews.llvm.org/D21453



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to