rnk added a comment.

lgtm

In D133817#3794429 <https://reviews.llvm.org/D133817#3794429>, @dblaikie wrote:

> So, I could leave a test case and some comments, or follow-up with a separate 
> fix for the homogenous aggregate issue? I guess it comes down to writing that 
> separate function to do the tests. (would be great to throw some of this at 
> the ABI fuzzer @majnemer had back in the day, at least I think he had an ABI 
> fuzzer of some sort, yeah?)

Right, we did have a record layout fuzzer which worked pretty well. I think it 
only ever ran on a workstation, it relied on custom tools and the like. I think 
it's lost to the sands of time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133817/new/

https://reviews.llvm.org/D133817

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to