jhuber6 added a comment. In D135305#3838490 <https://reviews.llvm.org/D135305#3838490>, @yaxunl wrote:
> In D135305#3838435 <https://reviews.llvm.org/D135305#3838435>, @jhuber6 wrote: > >> In D135305#3838412 <https://reviews.llvm.org/D135305#3838412>, @yaxunl wrote: >> >>> should we test with -ccc-print-phases instead? It is not clear what actions >>> are produced by driver. >> >> Ah, realized you meant with phases. This is good enough for NVPTX as there >> is no explicit `assembler` phase. LTO makes no difference for AMDGPU as it >> already outputs bitcode. > > It is not clear whether the driver respects -foffload-lto when -fno-gpu-rdc > is specified. -ccc-print-phases shows whether the driver generates bc or > object. -ccc-print-bindings does not because it does not show the file types. There's an existing test in the OpenMP toolchain that uses phases I believe, using bindings was just easier for making the tests. If you think it's worth changing then I'll do it, but it was just easier this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135305/new/ https://reviews.llvm.org/D135305 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
