kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
================
Comment at: clang/lib/Format/FormatTokenLexer.cpp:767
if (Offset[0] == '\\') {
++Offset; // Skip the escaped character.
} else if (Offset + 1 < Lex->getBuffer().end() && Offset[0] == '$' &&
----------------
it's a separate concern, but feels like this could also trigger some crashes
(e.g. an input like "`\")
================
Comment at: clang/lib/Format/FormatTokenLexer.cpp:772
StateStack.push(LexerState::NORMAL);
++Offset;
+ ++Offset;
----------------
nit: `Offset += 2;` instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135356/new/
https://reviews.llvm.org/D135356
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
