erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
LGTM... Please do the re-ordering separately here, unless it was necessary here.
================
Comment at: clang/lib/Parse/ParseExpr.cpp:1071
REVERTIBLE_TYPE_TRAIT(__is_base_of);
+ REVERTIBLE_TYPE_TRAIT(__is_bounded_array);
REVERTIBLE_TYPE_TRAIT(__is_class);
----------------
Can you just put this in the right place in the other commit?
================
Comment at: clang/lib/Parse/ParseExpr.cpp:1078
REVERTIBLE_TYPE_TRAIT(__is_convertible_to);
+ REVERTIBLE_TYPE_TRAIT(__is_convertible);
REVERTIBLE_TYPE_TRAIT(__is_destructible);
----------------
Why are the rest of these re-ordered? Feel free to do an NFC re-ordering
these, but please dont do them here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135177/new/
https://reviews.llvm.org/D135177
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
