goncharov added a comment. In D135220#3840177 <https://reviews.llvm.org/D135220#3840177>, @dexonsmith wrote:
> In D135220#3839671 <https://reviews.llvm.org/D135220#3839671>, @goncharov > wrote: > >> That change might be problematic for content addressing storages. E.g. >> clang/test/Driver/cl-pch-showincludes.cpp started to fail in my setup as >> clang/test/Driver/header{0,1,3,4}.h are all identical and can be symlinked. >> cc @dexonsmith > > FWIW, I agree with Ben that this change seems like it should improve > consistency for symlinked content. Knowing the failure mode / having > reproduction steps would be helpful to track down your corner case! > > (There are many subtle interactions around this stuff in clang so it’s hard > to make forward progress.) What I see in this clang/test/Driver/cl-pch-showincludes.cpp is that e.g. for run on :25 it now emits Note: including file: ...header2.h Note: including file: ...header1.h Note: including file: ...header1.h instead of Note: including file: ...header2.h Note: including file: ...header1.h Note: including file: ...header3.h as header3 -> header1. It's possbile to make it deterministic by making headers unique though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135220/new/ https://reviews.llvm.org/D135220 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
