aaron.ballman added inline comments.
================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:446
+ if (Optional<PrimType> T = classify(LitType)) {
+ APInt Val(getIntWidth(LitType), E->getValue());
+ return this->emitConst(*T, 0, Val, E);
----------------
Should this be concerned about the sign of the promoted literal?
================
Comment at: clang/test/AST/Interp/arrays.cpp:135
+ static_assert(u32[1] == U'b', "");
+};
+
----------------
I think you need a more coverage for character literals. Some test cases that
are interesting: multichar literals (`'abcd'`), character literals with UCNs
(`'\uFFFF'`), character literals with numeric escapes (`'\xFF'`). I'm
especially interested in seeing whether we handle integer promotions properly,
especially when promoting to `unsigned int`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135366/new/
https://reviews.llvm.org/D135366
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
