jcranmer-intel added inline comments.
================
Comment at: clang/lib/AST/ExprConstant.cpp:14029-14030
+ case Builtin::BI__builtin_fmaxf16:
+ case Builtin::BI__builtin_fmaxf128: {
+ APFloat RHS(0.);
+ if (!EvaluateFloat(E->getArg(0), Result, Info) ||
----------------
I think you should add a comment saying `// TODO: Handle sNaN`, just so that we
remember to revisit this later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134369/new/
https://reviews.llvm.org/D134369
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
