alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed.
In many cases a transitively included header can be considered a part of a public interface of an already included header, e.g. it's reasonable to assume that DiagnosticIDs.h is a part of the public API exposed by Diagnostics.h. Thus, I consider IWYU fixes useless or even mildly harmful until (most of) LLVM/Clang headers are properly annotated with `// IWYU pragma: export` etc. The other change seems fine, if you have properly verified the new behavior. Repository: rL LLVM https://reviews.llvm.org/D22656 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
