This revision was automatically updated to reflect the committed changes.
Closed by commit rGe78165f0ba1e: [clangd] Block clang-tidy
misc-const-correctness check (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135829/new/
https://reviews.llvm.org/D135829
Files:
clang-tools-extra/clangd/TidyProvider.cpp
Index: clang-tools-extra/clangd/TidyProvider.cpp
===================================================================
--- clang-tools-extra/clangd/TidyProvider.cpp
+++ clang-tools-extra/clangd/TidyProvider.cpp
@@ -212,8 +212,14 @@
// code, which is often the case when clangd
// tries to build an AST.
"-bugprone-use-after-move",
- // Alias for bugprone-use-after-moe.
- "-hicpp-invalid-access-moved");
+ // Alias for bugprone-use-after-move.
+ "-hicpp-invalid-access-moved",
+
+ // ----- Performance problems -----
+
+ // This check runs expensive analysis for each variable.
+ // It has been observed to increase reparse time by 10x.
+ "-misc-const-correctness");
size_t Size = BadChecks.size();
for (const std::string &Str : ExtraBadChecks) {
Index: clang-tools-extra/clangd/TidyProvider.cpp
===================================================================
--- clang-tools-extra/clangd/TidyProvider.cpp
+++ clang-tools-extra/clangd/TidyProvider.cpp
@@ -212,8 +212,14 @@
// code, which is often the case when clangd
// tries to build an AST.
"-bugprone-use-after-move",
- // Alias for bugprone-use-after-moe.
- "-hicpp-invalid-access-moved");
+ // Alias for bugprone-use-after-move.
+ "-hicpp-invalid-access-moved",
+
+ // ----- Performance problems -----
+
+ // This check runs expensive analysis for each variable.
+ // It has been observed to increase reparse time by 10x.
+ "-misc-const-correctness");
size_t Size = BadChecks.size();
for (const std::string &Str : ExtraBadChecks) {
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
