iains added a comment. In D134267#3861615 <https://reviews.llvm.org/D134267#3861615>, @ChuanqiXu wrote:
> Address @tschuett's opinion: > > - Use new introduced -fc++-module-cache-path= instead of -fc++-module-path to > avoid many logics about modules cache in clang modules. > - Use new introduced `-fmodule-bmi-output=` instead of `-fmodule-name` for > the same reason. Also `-fmodule-bmi-output=` is more flexible since > `-fmodule-name` require its argument to be the same with the actual module > name. I think the second one is too much "implementor-speak" as a user-facing option name, perhaps keep it consistent with the first and make it something like "-fc++-module-filename=" (unless it can be a path - in which case -fc++-module-pathname=). Although modular code is user-facing - BMIs are an implementational detail, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134267/new/ https://reviews.llvm.org/D134267 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
