efriedma added a comment.
> I am thinking about adding a new option, say -mgot-calls to allow code
> generation with the extra indirection. Is it sensible and shall I create
> another diff to discuss that?
That probably makes sense, yes.
================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:2655
+ // support movw movt, so we are safe to assume that.
+ if (Subtarget->genExecuteOnly()) {
+ SDValue GA = DAG.getTargetGlobalAddress(GVal, dl, PtrVt);
----------------
Can we directly check that movw/movt is available? I think that's what we do
in other places? (Then just assert we aren't execute-only in the non-movw
path.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136203/new/
https://reviews.llvm.org/D136203
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
