aaron.ballman added a comment.

Thank you for the fix!

Can you add test coverage to show the behavioral change? You can either 
position the problematic null argument on its own line (so you can validate the 
correct position) or use `-fdiagnostics-print-source-range-info` to check a 
specific range. Also, can you add a release note about the fix to 
`clang/docs/ReleaseNotes.rst`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136355/new/

https://reviews.llvm.org/D136355

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D1363... Arthur Grillo Queiroz Cabral via Phabricator via cfe-commits
    • [PATCH] ... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] ... Arthur Grillo Queiroz Cabral via Phabricator via cfe-commits
    • [PATCH] ... Arthur Grillo Queiroz Cabral via Phabricator via cfe-commits
    • [PATCH] ... Arthur Grillo Queiroz Cabral via Phabricator via cfe-commits
    • [PATCH] ... Arthur Grillo Queiroz Cabral via Phabricator via cfe-commits
    • [PATCH] ... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] ... Arthur Grillo Queiroz Cabral via Phabricator via cfe-commits
    • [PATCH] ... Aaron Ballman via Phabricator via cfe-commits

Reply via email to