tbaeder added inline comments.
================ Comment at: clang/test/AST/Interp/literals.cpp:426 + } + static_assert(subAll(213) == 0); + ---------------- aaron.ballman wrote: > We also need tests for failure situations: > ``` > constexpr int func() { > int i = __INT_MAX__; > i += 1; // oops > return i; > } > > constexpr int another() { > int i = __INT_MIN__; > i -= 1; // oops > return i; > } > ``` woops, I was sure I added this but it was for the `++`/`--` patch it seems. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136528/new/ https://reviews.llvm.org/D136528 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits