shafik accepted this revision. shafik added a comment. LGTM
================ Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1258 + } + case UO_PreDec: { // --x + if (!this->visit(SubExpr)) ---------------- You could combine this with `UO_PreInc` and just use a `bool` flag to determine whether to call `emitAdd` or `emitSub` . Although maybe that it too clever. ================ Comment at: clang/test/AST/Interp/literals.cpp:364 }; + +#if __cplusplus > 201402L ---------------- Fun tests ``` +[](){}; +'a'; ``` The action will really be done by the casts but the `+` is still technically having that affect. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136423/new/ https://reviews.llvm.org/D136423 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits