kadircet updated this revision to Diff 470558.
kadircet marked 5 inline comments as done.
kadircet added a comment.
- Rename Related to Ambigious in RefKind
- Add more tests for implicit constructor calls
- Default to Explicit as RefKind when reporting references
- Don't report unused overloads, unless reference is inside a header
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135859/new/
https://reviews.llvm.org/D135859
Files:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h
clang-tools-extra/include-cleaner/lib/Analysis.cpp
clang-tools-extra/include-cleaner/lib/AnalysisInternal.h
clang-tools-extra/include-cleaner/lib/HTMLReport.cpp
clang-tools-extra/include-cleaner/lib/WalkAST.cpp
clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp
clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp
Index: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp
===================================================================
--- clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp
+++ clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp
@@ -12,11 +12,15 @@
#include "clang/Frontend/TextDiagnostic.h"
#include "clang/Testing/TestAST.h"
#include "llvm/ADT/ArrayRef.h"
+#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Error.h"
+#include "llvm/Support/ErrorHandling.h"
#include "llvm/Testing/Support/Annotations.h"
#include "gmock/gmock.h"
#include "gtest/gtest.h"
#include <cstddef>
+#include <unordered_map>
+#include <utility>
#include <vector>
namespace clang::include_cleaner {
@@ -24,13 +28,27 @@
using testing::Pair;
using testing::UnorderedElementsAre;
-// Specifies a test of which symbols are referenced by a piece of code.
-//
+llvm::StringLiteral to_string(RefType RT) {
+ switch (RT) {
+ case RefType::Explicit:
+ return "explicit";
+ case RefType::Implicit:
+ return "implicit";
+ case RefType::Ambigious:
+ return "ambigious";
+ }
+ llvm_unreachable("Unexpected RefType");
+}
+
+// Specifies a test of which symbols are referenced by a piece of code. When
+// IsHeader is true, treats referencing code as a header file.
+// Target should contain points annotated with the reference kind.
// Example:
-// Target: int ^foo();
+// Target: int $explicit^foo();
// Referencing: int x = ^foo();
// There must be exactly one referencing location marked.
-void testWalk(llvm::StringRef TargetCode, llvm::StringRef ReferencingCode) {
+void testWalk(llvm::StringRef TargetCode, llvm::StringRef ReferencingCode,
+ bool IsHeader = false) {
llvm::Annotations Target(TargetCode);
llvm::Annotations Referencing(ReferencingCode);
@@ -39,6 +57,8 @@
Inputs.ExtraArgs.push_back("-include");
Inputs.ExtraArgs.push_back("target.h");
Inputs.ExtraArgs.push_back("-std=c++17");
+ if (IsHeader)
+ Inputs.ExtraArgs.push_back("-xc++-header");
TestAST AST(Inputs);
const auto &SM = AST.sourceManager();
@@ -51,20 +71,21 @@
llvm::cantFail(AST.fileManager().getFileRef("target.h")));
// Perform the walk, and capture the offsets of the referenced targets.
- std::vector<size_t> ReferencedOffsets;
+ std::unordered_map<RefType, std::vector<size_t>> ReferencedOffsets;
for (Decl *D : AST.context().getTranslationUnitDecl()->decls()) {
if (ReferencingFile != SM.getDecomposedExpansionLoc(D->getLocation()).first)
continue;
- walkAST(*D, [&](SourceLocation Loc, NamedDecl &ND) {
+ walkAST(*D, [&](SourceLocation Loc, NamedDecl &ND, RefType RT) {
if (SM.getFileLoc(Loc) != ReferencingLoc)
return;
auto NDLoc = SM.getDecomposedLoc(SM.getFileLoc(ND.getLocation()));
if (NDLoc.first != TargetFile)
return;
- ReferencedOffsets.push_back(NDLoc.second);
+ ReferencedOffsets[RT].push_back(NDLoc.second);
});
}
- llvm::sort(ReferencedOffsets);
+ for (auto &Entry : ReferencedOffsets)
+ llvm::sort(Entry.second);
// Compare results to the expected points.
// For each difference, show the target point in context, like a diagnostic.
@@ -74,17 +95,22 @@
DiagOpts->ShowLevel = 0;
DiagOpts->ShowNoteIncludeStack = 0;
TextDiagnostic Diag(DiagOS, AST.context().getLangOpts(), DiagOpts);
- auto DiagnosePoint = [&](const char *Message, unsigned Offset) {
+ auto DiagnosePoint = [&](llvm::StringRef Message, unsigned Offset) {
Diag.emitDiagnostic(
FullSourceLoc(SM.getComposedLoc(TargetFile, Offset), SM),
DiagnosticsEngine::Note, Message, {}, {});
};
- for (auto Expected : Target.points())
- if (!llvm::is_contained(ReferencedOffsets, Expected))
- DiagnosePoint("location not marked used", Expected);
- for (auto Actual : ReferencedOffsets)
- if (!llvm::is_contained(Target.points(), Actual))
- DiagnosePoint("location unexpectedly used", Actual);
+ for (auto RT : {RefType::Explicit, RefType::Implicit, RefType::Ambigious}) {
+ auto RTStr = to_string(RT);
+ for (auto Expected : Target.points(RTStr))
+ if (!llvm::is_contained(ReferencedOffsets[RT], Expected))
+ DiagnosePoint(("location not marked used with type " + RTStr).str(),
+ Expected);
+ for (auto Actual : ReferencedOffsets[RT])
+ if (!llvm::is_contained(Target.points(RTStr), Actual))
+ DiagnosePoint(("location unexpectedly used with type " + RTStr).str(),
+ Actual);
+ }
// If there were any differences, we print the entire referencing code once.
if (!DiagBuf.empty())
@@ -92,35 +118,47 @@
}
TEST(WalkAST, DeclRef) {
- testWalk("int ^x;", "int y = ^x;");
- testWalk("int ^foo();", "int y = ^foo();");
- testWalk("namespace ns { int ^x; }", "int y = ns::^x;");
- testWalk("struct S { static int ^x; };", "int y = S::^x;");
+ testWalk("int $explicit^x;", "int y = ^x;");
+ testWalk("int $explicit^foo();", "int y = ^foo();");
+ testWalk("namespace ns { int $explicit^x; }", "int y = ns::^x;");
+ testWalk("struct S { static int $explicit^x; };", "int y = S::^x;");
// Canonical declaration only.
- testWalk("extern int ^x; int x;", "int y = ^x;");
+ testWalk("extern int $explicit^x; int x;", "int y = ^x;");
// Return type of `foo` isn't used.
- testWalk("struct S{}; S ^foo();", "auto bar() { return ^foo(); }");
+ testWalk("struct S{}; S $explicit^foo();", "auto bar() { return ^foo(); }");
}
TEST(WalkAST, TagType) {
- testWalk("struct ^S {};", "^S *y;");
- testWalk("enum ^E {};", "^E *y;");
- testWalk("struct ^S { static int x; };", "int y = ^S::x;");
+ testWalk("struct $explicit^S {};", "^S *y;");
+ testWalk("enum $explicit^E {};", "^E *y;");
+ testWalk("struct $explicit^S { static int x; };", "int y = ^S::x;");
}
TEST(WalkAST, Alias) {
testWalk(R"cpp(
namespace ns { int x; }
- using ns::^x;
+ using ns::$explicit^x;
)cpp",
"int y = ^x;");
- testWalk("using ^foo = int;", "^foo x;");
- testWalk("struct S {}; using ^foo = S;", "^foo x;");
+ testWalk("using $explicit^foo = int;", "^foo x;");
+ testWalk("struct S {}; using $explicit^foo = S;", "^foo x;");
}
TEST(WalkAST, Using) {
- testWalk("namespace ns { void ^x(); void ^x(int); }", "using ns::^x;");
- testWalk("namespace ns { struct S; } using ns::^S;", "^S *s;");
+ // Make sure we ignore unused overloads.
+ testWalk(R"cpp(
+ namespace ns {
+ void $explicit^x(); void x(int); void x(char);
+ })cpp",
+ "using ns::^x; void foo() { x(); }");
+ // We should report unused overloads if main file is a header.
+ testWalk(R"cpp(
+ namespace ns {
+ void $ambigious^x(); void $ambigious^x(int); void $ambigious^x(char);
+ })cpp",
+ "using ns::^x;",
+ /*IsHeader=*/true);
+ testWalk("namespace ns { struct S; } using ns::$explicit^S;", "^S *s;");
}
TEST(WalkAST, Namespaces) {
@@ -128,51 +166,55 @@
}
TEST(WalkAST, TemplateNames) {
- testWalk("template<typename> struct ^S {};", "^S<int> s;");
+ testWalk("template<typename> struct $explicit^S {};", "^S<int> s;");
// FIXME: Template decl has the wrong primary location for type-alias template
// decls.
testWalk(R"cpp(
template <typename> struct S {};
- template <typename T> ^using foo = S<T>;)cpp",
+ template <typename T> $explicit^using foo = S<T>;)cpp",
"^foo<int> x;");
testWalk(R"cpp(
namespace ns {template <typename> struct S {}; }
- using ns::^S;)cpp",
+ using ns::$explicit^S;)cpp",
"^S<int> x;");
- testWalk("template<typename> struct ^S {};",
+ testWalk("template<typename> struct $explicit^S {};",
R"cpp(
template <template <typename> typename> struct X {};
X<^S> x;)cpp");
- testWalk("template<typename T> struct ^S { S(T); };", "^S s(42);");
+ testWalk("template<typename T> struct $explicit^S { S(T); };", "^S s(42);");
// Should we mark the specialization instead?
- testWalk("template<typename> struct ^S {}; template <> struct S<int> {};",
- "^S<int> s;");
+ testWalk(
+ "template<typename> struct $explicit^S {}; template <> struct S<int> {};",
+ "^S<int> s;");
}
TEST(WalkAST, MemberExprs) {
- testWalk("struct S { void ^foo(); };", "void foo() { S{}.^foo(); }");
- testWalk("struct S { void foo(); }; struct X : S { using S::^foo; };",
- "void foo() { X{}.^foo(); }");
+ testWalk("struct S { void $explicit^foo(); };", "void foo() { S{}.^foo(); }");
+ testWalk(
+ "struct S { void foo(); }; struct X : S { using S::$explicit^foo; };",
+ "void foo() { X{}.^foo(); }");
}
TEST(WalkAST, ConstructExprs) {
- testWalk("struct ^S {};", "S ^t;");
- testWalk("struct S { ^S(int); };", "S ^t(42);");
+ testWalk("struct $implicit^S {};", "S ^t;");
+ testWalk("struct S { $implicit^S(); };", "S ^t;");
+ testWalk("struct S { $explicit^S(int); };", "S ^t(42);");
+ testWalk("struct S { $implicit^S(int); };", "S t = ^42;");
}
TEST(WalkAST, Functions) {
// Definition uses declaration, not the other way around.
- testWalk("void ^foo();", "void ^foo() {}");
+ testWalk("void $explicit^foo();", "void ^foo() {}");
testWalk("void foo() {}", "void ^foo();");
// Unresolved calls marks all the overloads.
- testWalk("void ^foo(int); void ^foo(char);",
+ testWalk("void $ambigious^foo(int); void $ambigious^foo(char);",
"template <typename T> void bar() { ^foo(T{}); }");
}
TEST(WalkAST, Enums) {
- testWalk("enum E { ^A = 42, B = 43 };", "int e = ^A;");
- testWalk("enum class ^E : int;", "enum class ^E : int {};");
+ testWalk("enum E { $explicit^A = 42, B = 43 };", "int e = ^A;");
+ testWalk("enum class $explicit^E : int;", "enum class ^E : int {};");
testWalk("enum class E : int {};", "enum class ^E : int ;");
}
Index: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp
===================================================================
--- clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp
+++ clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp
@@ -49,7 +49,7 @@
auto &SM = AST.sourceManager();
llvm::DenseMap<size_t, std::vector<Header>> OffsetToProviders;
- walkUsed(TopLevelDecls, [&](SourceLocation RefLoc, Symbol S,
+ walkUsed(TopLevelDecls, [&](SourceLocation RefLoc, Symbol S, RefType RT,
llvm::ArrayRef<Header> Providers) {
auto [FID, Offset] = SM.getDecomposedLoc(RefLoc);
EXPECT_EQ(FID, SM.getMainFileID());
Index: clang-tools-extra/include-cleaner/lib/WalkAST.cpp
===================================================================
--- clang-tools-extra/include-cleaner/lib/WalkAST.cpp
+++ clang-tools-extra/include-cleaner/lib/WalkAST.cpp
@@ -7,6 +7,7 @@
//===----------------------------------------------------------------------===//
#include "AnalysisInternal.h"
+#include "clang-include-cleaner/Analysis.h"
#include "clang/AST/Decl.h"
#include "clang/AST/DeclCXX.h"
#include "clang/AST/Expr.h"
@@ -21,10 +22,15 @@
namespace clang::include_cleaner {
namespace {
-using DeclCallback = llvm::function_ref<void(SourceLocation, NamedDecl &)>;
+using DeclCallback =
+ llvm::function_ref<void(SourceLocation, NamedDecl &, RefType)>;
class ASTWalker : public RecursiveASTVisitor<ASTWalker> {
DeclCallback Callback;
+ // Whether we're traversing declarations coming from a header file.
+ // This helps figure out whether certain symbols can be assumed as unused
+ // (e.g. overloads brought into an implementation file, but not used).
+ bool IsHeader = false;
bool handleTemplateName(SourceLocation Loc, TemplateName TN) {
// For using-templates, only mark the alias.
@@ -36,14 +42,16 @@
return true;
}
- void report(SourceLocation Loc, NamedDecl *ND) {
+ void report(SourceLocation Loc, NamedDecl *ND,
+ RefType RT = RefType::Explicit) {
if (!ND || Loc.isInvalid())
return;
- Callback(Loc, *cast<NamedDecl>(ND->getCanonicalDecl()));
+ Callback(Loc, *cast<NamedDecl>(ND->getCanonicalDecl()), RT);
}
public:
- ASTWalker(DeclCallback Callback) : Callback(Callback) {}
+ ASTWalker(DeclCallback Callback, bool IsHeader)
+ : Callback(Callback), IsHeader(IsHeader) {}
bool VisitDeclRefExpr(DeclRefExpr *DRE) {
report(DRE->getLocation(), DRE->getFoundDecl());
@@ -56,23 +64,31 @@
}
bool VisitCXXConstructExpr(CXXConstructExpr *E) {
- report(E->getLocation(), E->getConstructor());
+ report(E->getLocation(), E->getConstructor(),
+ E->getParenOrBraceRange().isValid() ? RefType::Explicit
+ : RefType::Implicit);
return true;
}
bool VisitOverloadExpr(OverloadExpr *E) {
// Since we can't prove which overloads are used, report all of them.
- // FIXME: Provide caller with the ability to make a decision for such uses.
- llvm::for_each(E->decls(),
- [this, E](NamedDecl *D) { report(E->getNameLoc(), D); });
+ llvm::for_each(E->decls(), [this, E](NamedDecl *D) {
+ report(E->getNameLoc(), D, RefType::Ambigious);
+ });
return true;
}
bool VisitUsingDecl(UsingDecl *UD) {
- // FIXME: Provide caller with the ability to tell apart used/non-used
- // targets.
- for (const auto *Shadow : UD->shadows())
- report(UD->getLocation(), Shadow->getTargetDecl());
+ for (const auto *Shadow : UD->shadows()) {
+ auto *TD = Shadow->getTargetDecl();
+ auto IsUsed = TD->isUsed() || TD->isReferenced();
+ // We ignore unused overloads inside implementation files, as the ones in
+ // headers might still be used by the dependents of the header.
+ if (!IsUsed && !IsHeader)
+ continue;
+ report(UD->getLocation(), TD,
+ IsUsed ? RefType::Explicit : RefType::Ambigious);
+ }
return true;
}
@@ -135,7 +151,8 @@
} // namespace
void walkAST(Decl &Root, DeclCallback Callback) {
- ASTWalker(Callback).TraverseDecl(&Root);
+ bool IsHeader = Root.getASTContext().getLangOpts().IsHeaderFile;
+ ASTWalker(Callback, IsHeader).TraverseDecl(&Root);
}
} // namespace clang::include_cleaner
Index: clang-tools-extra/include-cleaner/lib/HTMLReport.cpp
===================================================================
--- clang-tools-extra/include-cleaner/lib/HTMLReport.cpp
+++ clang-tools-extra/include-cleaner/lib/HTMLReport.cpp
@@ -14,6 +14,7 @@
//===----------------------------------------------------------------------===//
#include "AnalysisInternal.h"
+#include "clang-include-cleaner/Analysis.h"
#include "clang/AST/ASTContext.h"
#include "clang/AST/Decl.h"
#include "clang/AST/PrettyPrinter.h"
@@ -212,8 +213,9 @@
llvm::raw_ostream &OS) {
Reporter R(OS, Ctx, File);
for (Decl *Root : Roots)
- walkAST(*Root,
- [&](SourceLocation Loc, const NamedDecl &D) { R.addRef(Loc, D); });
+ walkAST(*Root, [&](SourceLocation Loc, const NamedDecl &D, RefType) {
+ R.addRef(Loc, D);
+ });
R.write();
}
Index: clang-tools-extra/include-cleaner/lib/AnalysisInternal.h
===================================================================
--- clang-tools-extra/include-cleaner/lib/AnalysisInternal.h
+++ clang-tools-extra/include-cleaner/lib/AnalysisInternal.h
@@ -21,6 +21,7 @@
#ifndef CLANG_INCLUDE_CLEANER_ANALYSISINTERNAL_H
#define CLANG_INCLUDE_CLEANER_ANALYSISINTERNAL_H
+#include "clang-include-cleaner/Analysis.h" // FIXME: Move RefType into a separate header.
#include "clang/Basic/SourceLocation.h"
#include "llvm/ADT/STLFunctionalExtras.h"
@@ -37,10 +38,13 @@
/// the primary location of the AST node found under Root.
/// - the NamedDecl is the symbol referenced. It is canonical, rather than e.g.
/// the redecl actually found by lookup.
+/// - the RefType describes the relation between the SourceLocation and the
+/// NamedDecl.
///
/// walkAST is typically called once per top-level declaration in the file
/// being analyzed, in order to find all references within it.
-void walkAST(Decl &Root, llvm::function_ref<void(SourceLocation, NamedDecl &)>);
+void walkAST(Decl &Root,
+ llvm::function_ref<void(SourceLocation, NamedDecl &, RefType)>);
/// Write an HTML summary of the analysis to the given stream.
/// FIXME: Once analysis has a public API, this should be public too.
Index: clang-tools-extra/include-cleaner/lib/Analysis.cpp
===================================================================
--- clang-tools-extra/include-cleaner/lib/Analysis.cpp
+++ clang-tools-extra/include-cleaner/lib/Analysis.cpp
@@ -31,17 +31,17 @@
tooling::stdlib::Recognizer Recognizer;
for (auto *Root : ASTRoots) {
auto &SM = Root->getASTContext().getSourceManager();
- walkAST(*Root, [&](SourceLocation Loc, NamedDecl &ND) {
+ walkAST(*Root, [&](SourceLocation Loc, NamedDecl &ND, RefType RT) {
if (auto SS = Recognizer(&ND)) {
// FIXME: Also report forward decls from main-file, so that the caller
// can decide to insert/ignore a header.
- return CB(Loc, Symbol(*SS), toHeader(SS->headers()));
+ return CB(Loc, Symbol(*SS), RT, toHeader(SS->headers()));
}
// FIXME: Extract locations from redecls.
// FIXME: Handle IWYU pragmas, non self-contained files.
// FIXME: Handle macro locations.
if (auto *FE = SM.getFileEntryForID(SM.getFileID(ND.getLocation())))
- return CB(Loc, Symbol(ND), {Header(FE)});
+ return CB(Loc, Symbol(ND), RT, {Header(FE)});
});
}
// FIXME: Handle references of macros.
Index: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h
===================================================================
--- clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h
+++ clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h
@@ -21,6 +21,16 @@
class FileEntry;
namespace include_cleaner {
+/// Indicates the relation between the reference and the target.
+enum class RefType {
+ /// Target is explicit from the reference, e.g. function call.
+ Explicit,
+ /// Target isn't spelled, e.g. default constructor call.
+ Implicit,
+ /// Target's use can't be proven, e.g. a candidate for an unresolved overload.
+ Ambigious,
+};
+
/// An entity that can be referenced in the code.
struct Symbol {
Symbol(Decl &D) : Storage(&D) {}
@@ -51,8 +61,9 @@
/// that symbol may be provided by several headers.
/// FIXME: Provide signals about the reference type and providing headers so the
/// caller can filter and rank the results.
-using UsedSymbolCB = llvm::function_ref<void(
- SourceLocation RefLoc, Symbol Target, llvm::ArrayRef<Header> Providers)>;
+using UsedSymbolCB =
+ llvm::function_ref<void(SourceLocation RefLoc, Symbol Target, RefType RT,
+ llvm::ArrayRef<Header> Providers)>;
/// Find and report all references to symbols in a region of code.
///
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
