ashi1 added inline comments.
================
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
----------------
yaxunl wrote:
> Anastasia wrote:
> > Can you move this error message down instead of adding 6 lines offset.
> > Also the extension seems to be set by default although it's hard to see
> > without the full diff. So why do you get this warning at all?
> This warning is only for opencl version < 200. The extension is supported by
> OpenCL 2.0 and above only.
I've added this error message here because I am following the order inside
include/clang/Basic/OpenCLExtensions.def. Seems it is alphabetical there and in
same order here. What do you think?
================
Comment at: test/SemaOpenCL/extension-version.cl:228
@@ +227,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
----------------
Anastasia wrote:
> Can you move this error message down instead of adding 6 lines offset.
I've added this error message here because I am following the order inside
include/clang/Basic/OpenCLExtensions.def. Seems it is alphabetical there and in
same order here. What do you think?
Repository:
rL LLVM
https://reviews.llvm.org/D22637
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
