[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

[Sjoerd Meijer via Phabricator via cfe-commits]

SjoerdMeijer added a reviewer: fhahn.
SjoerdMeijer added inline comments.


================
Comment at: clang/lib/Parse/ParsePragma.cpp:1306
   StringRef Str = PragmaName.getIdentifierInfo()->getName();
+  if (Str == "loop")
+    return (llvm::Twine("clang loop ") + 
Option.getIdentifierInfo()->getName()).str();
----------------
We've got some duplication now, as "loop" is also checked in line 1310. Can you 
see if you can merge these checks, simplify things here a bit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136784/new/

https://reviews.llvm.org/D136784

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits