thakis added a comment. In D136474#3888455 <https://reviews.llvm.org/D136474#3888455>, @aganea wrote:
> In D136474#3888330 <https://reviews.llvm.org/D136474#3888330>, @thakis wrote: > >>> I read that, and I'm indicating that I don't agree. Chromium's requirements >>> are driven by its particular usage of a cross-compiling distributed build >>> system, which may not represent the average user's needs. >> >> Are you saying that it's a good thing if clang produces different output on >> different hosts? > > Objectively speaking, flags that change the terminal output, or more > generally don't affect the output artifact, shouldn't be part of the > reproducer. It was an oversight on my end when I initially implemented the > feature. Back at Ubisoft we had the same goal as you do, ie. build for a > given platform and end up with the same results, regardless of the host. But > that was never completed after I left. My view is that we should first add > the flag to allow disabling the reproducer, and then in subsequent patches > try to remove irrelevant flags from the reproducer. That sounds good to me, assuming that you have someone concrete in mind for who "we" is who's removing the irrelevant flags :) But if nobody's in charge of that at the moment, imho it makes sense to make this default-off until it no longer regresses determinism. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
