sepavloff added inline comments.
================ Comment at: clang/lib/AST/Interp/PrimType.h:39 PT_Bool, + PT_Float, PT_Ptr, ---------------- tbaeder wrote: > sepavloff wrote: > > In contrast to other members of this enumeration, `PT_Float` does not > > designate a concrete type, and it must creates problems. For example, how > > function `primSize(PrimType Type)` can be implemented? > Yes, floats are a bit special, see also the special case in `getCtorPrim()` > in `Descriptor.cpp`. But I don't think it's a problem for `primSize()` since > that only uses `sizeof()`. `sizeof` in `primSize()` would return `sizeof(clang::interp::Floating)`, which is `sizeof(APFloat)`. This value is not the same as `sizeof(float)` or `sizeof(double)`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
