zahiraam added a comment.

The changes in this patch look good to me. 
I talked to @andrew.w.kaylor offline: I was thinking that it might be necessary 
to make the two driver changes we talked about, before merging this patch. But 
if the tests pass then I think it's okay to implement the driver changes in an 
upcoming patch.
@michele.scandale please make sure not to drop the driver changes that we 
agreed upon in this patch. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136786/new/

https://reviews.llvm.org/D136786

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to