One of the reasons we added the minimum was because these nodes added overhead to the matching that was not unnecessary when they only had a single node. On the current implementation we could actually get rid of the node completely for the one argument calls. I would be ok with removing the lower bound.
On Tue, Jul 26, 2016 at 6:20 PM, Zac Hansen <xax...@gmail.com> wrote: > I was wondering if there is any objection to removing the 2-element > minimum on the eachOf, anyOf and allOf matchers. > > It is frustrating when playing with matchers to have to edit significant > amounts of code to be able to temporarily go from 2 to 1 matcher inside an > any- or allOf matcher. > > And overall it feels very "un-set-theory"-like. > > The change was made here: > https://github.com/llvm-mirror/clang/commit/674e54c167eab0be7a54bca7082c07d2f1d0c8cc > > > Thank you and apologies if I sent this to the wrong lists/people. > > --Zac >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
